Skip to content

[12.0-stable] Avoid nil dereference in baseosmgr #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

[12.0-stable] Avoid nil dereference in baseosmgr #4577

merged 1 commit into from
Feb 4, 2025
+1 −1

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 31, 2025 •
edited by OhmSpectator
Loading

  • avoid nil dereference

Signed-off-by: Mikhail Malyshev mike.malyshev@gmail.com
(cherry picked from commit 6bac1ef)

backport #4563

@rucoder rucoder requested a review from deitch as a code owner January 31, 2025 14:50
@rucoder rucoder requested a review from OhmSpectator January 31, 2025 14:51
@github-actions github-actions bot requested a review from eriknordmark January 31, 2025 14:51
@rucoder rucoder mentioned this pull request Jan 31, 2025
Merged
2 tasks
eriknordmark
eriknordmark approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene
Copy link
Contributor

rene commented Feb 3, 2025

@rucoder , could you please rebase your PR so it can get the fixes for Eden tests?

@rucoder rucoder force-pushed the rucoder/bp-12.0-pr4563 branch from 34117f1 to 2edf69c Compare February 3, 2025 16:17
@github-actions github-actions bot requested a review from eriknordmark February 3, 2025 16:18
@rucoder
Copy link
Contributor Author

rucoder commented Feb 3, 2025

@rene "pull rate limit" :)

@rene
Copy link
Contributor

rene commented Feb 3, 2025

@rene "pull rate limit" :)

Trying it again....

@OhmSpectator
Copy link
Member

@yash-zededa, it looks like the artifact action still fails in 12.0 :(

@yash-zededa
Copy link
Collaborator

@yash-zededa, it looks like the artifact action still fails in 12.0 :(

#4584 - this PR should fix it.

@eriknordmark
Copy link
Contributor

Please rebase this once #4584 has been merged

@OhmSpectator
Copy link
Member

@rucoder , rebase on the latest 12.0-stable, please =)

@rucoder @OhmSpectator
Avoid nil dereference in baseosmgr

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 7AF6CD6A8B93F50D
Learn about vigilant mode
Loading
Loading status checks…
93f6166 
- avoid nil dereference

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
(cherry picked from commit 6bac1ef)
@OhmSpectator OhmSpectator force-pushed the rucoder/bp-12.0-pr4563 branch from 2edf69c to 93f6166 Compare February 4, 2025 12:00
@OhmSpectator
Copy link
Member

Rebased on top of the latest 12.0-stable

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.51%. Comparing base (595e684) to head (93f6166).
Report is 29 commits behind head on 12.0-stable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           12.0-stable    #4577   +/-   ##
============================================
  Coverage        17.51%   17.51%           
============================================
  Files                3        3           
  Lines              805      805           
============================================
  Hits               141      141           
  Misses             629      629           
  Partials            35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yash-zededa yash-zededa self-requested a review February 4, 2025 12:50
@yash-zededa
Copy link
Collaborator

Approved to trigger the eden tests.

@OhmSpectator
Copy link
Member

OhmSpectator commented Feb 4, 2025 •
edited
Loading

Run ./eden stop
/home/runner/actions-runner/_work/_temp/c8e5f740-9b18-4533-ad9b-2ad0510f60c4.sh: line 1: ./eden: No such file or directory

@yash-zededa, it looks like it does not work again... We have to fix it soon, as we need a new 12.0-stable release soon...

@yash-zededa
Copy link
Collaborator

Run ./eden stop
/home/runner/actions-runner/_work/_temp/c8e5f740-9b18-4533-ad9b-2ad0510f60c4.sh: line 1: ./eden: No such file or directory

@yash-zededa, it looks like it does not work again... We have to fix it soon, as we need a new 12.0-stable release soon...

The issue seems to be with the network. Re-ran the jobs..

E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/q/qemu/qemu-system-gui_6.2%2bdfsg-2ubuntu6.24_amd64.deb  Cannot initiate the connection to archive.ubuntu.com:80 (2620:2d:4000:1::101). - connect (101: Network is unreachable) Cannot initiate the connection to archive.ubuntu.com:80 (2620:2d:4002:1::102). - connect (101: Network is unreachable) Cannot initiate the connection to archive.ubuntu.com:80 (2620:2d:4000:1::102). - connect (101: Network is unreachable) Cannot initiate the connection to archive.ubuntu.com:80 (2620:2d:4002:1::101). - connect (101: Network is unreachable) Cannot initiate the connection to archive.ubuntu.com:80 (2620:2d:4002:1::103

@OhmSpectator
Copy link
Member

@yash-zededa, and what about this one?

time="2025-02-04T14:02:34Z" level=info msg="cannot stop EVE: cannot open pid file /home/runner/actions-runner/_work/eve/eve/eden/dist/default-eve.pid: open /home/runner/actions-runner/_work/eve/eve/eden/dist/default-eve.pid: no such file or directory"

Is it kind of expected?...

@yash-zededa
Copy link
Collaborator

no such file or directory

I think so yes. The actual issue seems to be

2025-02-04T14:17:40.1374998Z ##[error][stdout]
Log/Info/Metric Test
=== RUN   TestLog
    lim_test.go:162: time: 2025-02-04T14:07:40.131989523Z out: Wait for log of 8dd64d9e-aadd-4c22-9b6f-d1ef1a9f0c7a number=1 timewait=10m0s
        
    testContext.go:291: WaitForProc terminated by timeout 10m0s
    testContext.go:274: WaitForProcWithErrorCallback terminated by timeout 10m0s
--- FAIL: TestLog (600.00s)
FAIL
[exit status 1]
FAIL: ../lim/testdata/log_test.txt:16: command failure

@OhmSpectator OhmSpectator merged commit 287f2c1 into lf-edge:12.0-stable Feb 4, 2025
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene rene

@OhmSpectator OhmSpectator

@yash-zededa yash-zededa

@deitch deitch

@eriknordmark eriknordmark

Assignees

@rucoder rucoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rucoder @rene @OhmSpectator @yash-zededa @eriknordmark